Chris Zubak-Skees

This collection includes notebooks for users of Github on Observable. 

Observable

Github on Observable

very nice, but I notice the drag on the dob filtering doesn't seem to work.

Mathew Brown

Ah, good catch! Not sure what's going on there.

super interesting! Both the histogram and categorical filters work with keyboard input but not mouse. I wonder if Observable is handling mouse events?

Amelia Wattenberger

I bet it's the shadow DOM I'm using to sandbox the styles.

Yeah, I think it's this https://github.com/downshift-js/downshift/issues/536

this also might be related, since it's both the histogram and downshift elements:
https://stackoverflow.com/questions/37866237/click-event-not-firing-when-react-component-in-a-shadow-dom

working sans shadow dom, but I see now why you were using it! wish those styles weren't bleeding out

https://observablehq.com/d/9b01d2fadfbab3c2

Okay, I think I got it. I inlined the styles unique to the app and used a CSS scoping function from @severo/scoped-css. Hopefully doesn't break something else.

Hi Chris!

I would love to see this but it looks like flat-viewer isn't working in Observable anymore, any ideas what the problem is?!

"Error: Minified React error #321; visit https://reactjs.org/docs/error-decoder.html?invariant=321 for the full message or use the non-minified dev environment for full errors and additional helpful warnings."

Thanks!

Declan Naughton

here's a backup until this one is working again:
https://observablehq.com/@wattenberger2/github-flat-viewer-in-observable

Thanks Amelia! 😀
Looks like all are back working again!

I merged the changes from your notebook. And added a credit line.